Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: hint in error message #8

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

prestwich
Copy link
Contributor

Adds a user-facing hint to the NoWasmFound error. A major cause seems to be having a lib.rs instead of a main.rs

Made using web UI. Didn't run linter or anything, sorry 😅

@cla-bot
Copy link

cla-bot bot commented Sep 12, 2023

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot
Copy link

cla-bot bot commented Sep 13, 2023

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@rauljordan
Copy link
Contributor

hi @prestwich really appreciate you taking a look at this and opening this PR. Just wondering if you can sign the attached CLA so we can merge this in. Thanks for your time!

@cla-bot
Copy link

cla-bot bot commented Sep 13, 2023

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@prestwich
Copy link
Contributor Author

In lieu of agreeing to the CLA, I've explicitly licensed the 6 words of my contribution and a comment describing exactly which content is reproduced under that license. Preserving the copyright notice in-line should cover any future licensing questions 👍

@rauljordan rauljordan merged commit fc6e15a into OffchainLabs:main Sep 19, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants