Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-2736] Lower URL case in latest database init #2589

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

gligneul
Copy link
Contributor

For non-default chains, the user specifies the chain name, leading to case inconsistencies in the resulting URL (e.g. Xai vs xai). This PR lowers the URL case to solve this problem.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 19, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit d1283ae into master Aug 19, 2024
13 checks passed
@joshuacolvin0 joshuacolvin0 deleted the gligneul/to-lower-latest-url branch August 19, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants