Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores gosec G115 #2597

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Ignores gosec G115 #2597

merged 1 commit into from
Aug 21, 2024

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented Aug 21, 2024

golangci-lint version 1.60.2 "broke" CI by pointing some overflow conversion issues in Nitro.

This PR disables this lint rule for now.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 21, 2024
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to open a PR :)
It seems to be broken indeed. There are a lot of complaints on gosec: securego/gosec#1185

@diegoximenes diegoximenes marked this pull request as ready for review August 21, 2024 15:02
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now, but I do think this is a useful lint. I'll follow up with a PR to re-enable this.

@PlasmaPower PlasmaPower merged commit 9a12710 into master Aug 21, 2024
15 checks passed
@PlasmaPower PlasmaPower deleted the ignore_g115 branch August 21, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants