Add safety check that min basefee must be positive for gas estimation #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
tsahee
reviewed
Aug 29, 2024
| @@ -69,6 +69,9 @@ func (con ArbOwner) SetL2BaseFee(c ctx, evm mech, priceInWei huge) error { | |||
|
|
|||
| // SetMinimumL2BaseFee sets the minimum base fee needed for a transaction to succeed | |||
| func (con ArbOwner) SetMinimumL2BaseFee(c ctx, evm mech, priceInWei huge) error { | |||
| if c.txProcessor.MsgIsNonMutating() && priceInWei.Sign() == 0 { | |||
There was a problem hiding this comment.
the idea is to only fail eth_call / gas estimation and leave normal operation unchanged?
There was a problem hiding this comment.
Yep. It should be fine to change normal operation too, but I think let's leave that for the next ArbOS version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.