Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support remote validator #2635

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support remote validator #2635

wants to merge 2 commits into from
+43 −13

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Sep 5, 2024 •
edited
Loading

Fixes: NIT-2717

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 5, 2024
@amsanghi amsanghi marked this pull request as ready for review September 5, 2024 07:28
tsahee
tsahee requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is enough..
We need a system test with 3 nodes:

  • one EatchTower node with block_validator enabled
  • one honest staker withuot block validator - uses 1st node as remote validator
  • one evil/wrong challenger
    We should see that the honest staker makes nodes, and protects it in a challenge. This node only has remote block_validator but has a stateless validator that's enough to execute it's own blocks for execution challenges.

Also, if you think it's better / simpler - this can be based off BOLD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amsanghi @tsahee