Add flag to disable DAS chunked stores #2796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
ganeshvanahalli
requested review from
Tristan-Wilson,
gligneul and
magicxyyz
| @@ -104,6 +105,7 @@ func parseClientStoreConfig(args []string) (*ClientStoreConfig, error) { | |||
| f.String("signing-wallet-password", genericconf.PASSWORD_NOT_SET, "password to unlock the wallet, if not specified the user is prompted for the password") | |||
| f.Duration("das-retention-period", 24*time.Hour, "The period which DASes are requested to retain the stored batches.") | |||
| f.Int("max-store-chunk-body-size", 512*1024, "The maximum HTTP POST body size for a chunked store request") | |||
| f.Bool("use-legacy-store", false, "enabling this forces the das rpc clients to use das_store. Disabled by default") | |||
There was a problem hiding this comment.
How about something like
disable-chunked-store, force data to always be sent to DAS all at once instead of splitting into chunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config option-
use-legacy-storethat forces the das rpc clients to usedas_store(legacy) instead ofdas_startChunkedStore.Resolves NIT-2949