-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Bot-Task-Module Sample Issues #844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one review comment.
MicrosoftAppID: "<<Microsoft-App-ID>>", | ||
BaseUrl: "<<BaseUrl>>" | ||
MicrosoftAppID: data.MicrosoftAppId, | ||
BaseUrl: `${window.location.origin}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it work in Desktop and mobile clients? ${window.location.origin}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harikrishnan-MSFT - Please run build pipeline as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working in Desktop clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks fine, approving it.
@@ -67,3 +67,10 @@ server.post('/api/messages', async (req, res) => { | |||
server.get('/*', restify.plugins.serveStatic({ | |||
directory: './pages' | |||
})); | |||
|
|||
server.get('/AuthTab', (req, res,next) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change name as "getAppConfiguration"
No description provided.