Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bot-Task-Module Sample Issues #844

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

Harikrishnan-MSFT
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one review comment.

MicrosoftAppID: "<<Microsoft-App-ID>>",
BaseUrl: "<<BaseUrl>>"
MicrosoftAppID: data.MicrosoftAppId,
BaseUrl: `${window.location.origin}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work in Desktop and mobile clients? ${window.location.origin}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harikrishnan-MSFT - Please run build pipeline as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working in Desktop clients.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine, approving it.

@@ -67,3 +67,10 @@ server.post('/api/messages', async (req, res) => {
server.get('/*', restify.plugins.serveStatic({
directory: './pages'
}));

server.get('/AuthTab', (req, res,next) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name as "getAppConfiguration"

@Prithvi-MSFT Prithvi-MSFT merged commit 1227bf2 into main Jul 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants