Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env deps not syncing after env yaml modified #12

Open
harelwa opened this issue Oct 18, 2023 · 4 comments
Open

env deps not syncing after env yaml modified #12

harelwa opened this issue Oct 18, 2023 · 4 comments

Comments

@harelwa
Copy link
Contributor

harelwa commented Oct 18, 2023

hi hi,

thank you very much for adding support to env yaml!

assuming an env is defined via env yaml, and was already created -

would you not expect syncing to occur after env yaml changes ? ( upon re-entry of course )

( i.e. behave the same as with regular / pypi deps )

From what i can see / experience now, it's not syncing.

Thanks!
Harel

@OldGrumpyViking
Copy link
Owner

Hi, can you give an example to a change in the env yaml that does not sync.

I agree that it would be best if the sync_dependencies call first calls syncs with env yaml before calling pip install when the dependencies_in_sync returns False.

@harelwa
Copy link
Contributor Author

harelwa commented Nov 2, 2023

hi, try any conda added dependency to env.yaml, and you’ll see — it does not update

@kunaltyagi
Copy link
Contributor

kunaltyagi commented Dec 1, 2023

I can confirm. Changing the env file doesn't update the env. It doesn't need any complicated setup.

name: test_conda

dependencies:
  - pip
  - pip:
    - pyyaml

Add any item to pip (or elsewhere) and confirm that the env is not updated

@kunaltyagi
Copy link
Contributor

I think the issue is that sync_dependencies doesn't check if the conda file has been updated.

Similarly, dependencies_in_sync doesn't check if conda file is any different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants