Detect changes in environment-file and update as needed

[kunaltyagi]

No description provided.

[kunaltyagi]

Fixes #12 (once complete)

Please let me know if this is the right direction to go towards

[kunaltyagi]

@OldGrumpyViking PTAL

[OldGrumpyViking]

Hi @kunaltyagi, thanks for this update. Please update the history.md and solve the conflict and i will merge it in and make a release.

[kunaltyagi]

PTAL

[harelwa]

Hi @kunaltyagi

Thank you for this PR.

I wanted to ask if this implementation is aligned (in spirit :) with hatch v1.8 improvements on the same topic https://hatch.pypa.io/1.8/blog/2023/12/11/hatch-v180/#faster-environment-usage ?

Thanks,

Harel

[kunaltyagi]

I dunno. Do we need to do something special?

I did modify the check function (https://hatch.pypa.io/latest/plugins/environment/reference/#hatch.env.plugin.interface.EnvironmentInterface.dependencies_in_sync), but let me know if we should add something else as well

[harelwa]

I dunno. Do we need to do something special?

I did modify the check function (https://hatch.pypa.io/latest/plugins/environment/reference/#hatch.env.plugin.interface.EnvironmentInterface.dependencies_in_sync), but let me know if we should add something else as well

I would review the hatch core implementation to and make sure the functionality is actually achieved and tested, as i'm not sure i understand how you avoid some sort of caching, checksum etc.

https://github.com/pypa/hatch/blob/7b1ef02af717101d006d9801bca6f246ecb46892/backend/src/hatchling/dep/core.py#L123

[kunaltyagi]

I don't think I need to. There are no suggestions or warnings in the docs, so the usage should be straightforward

Please let me know if you have seen some regression. Otherwise I don't want to spend time on something that the plugin api should achieve automatically

[harelwa]

@OldGrumpyViking

I see you have merged this to main.

Please do not publish this, it's breaking the very basic usage of this plugin.

This PR needs more tests to literally prove it's doing what it's suppose to be doing (i'm not sure it does, it's not really tested)

It also needs to prove it's not degrading "built in" sync when dependencies in hatch.toml env def are changed ( another required test ).

Unfortunately i do not have time to further dive into it.

Thanks,
Harel

[OldGrumpyViking]

@kunaltyagi can you address the issues mentioned by @harelwa.

[kunaltyagi]

Created pr to do that