Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not capture output when running commands #20

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

harelwa
Copy link
Contributor

@harelwa harelwa commented Jan 8, 2024

This PR solves #13

this PR simply aligns the behavior of hatch-conda with the behavior of hatch built in envs.

to see / reproduce the issue you can ( this is an overkill. sorry )

➜ hatch new luli
➜ cd luli

add hatch.toml with -

[envs.docs]
type = "conda"
command = "mamba"

dependencies = [
  "mkdocs~=1.5.3",
]

Init mkdocs -

➜ hatch run docs:mkdocs new .
➜ hatch run docs:mkdocs serve

before adding --no-capture-output to the mamba / conda / micromamba run command, nothing is printed to console. after added you get --

➜ hatch run docs:mkdocs serve
INFO    -  Building documentation...
INFO    -  Cleaning site directory
INFO    -  Documentation built in 0.07 seconds
INFO    -  [16:34:55] Watching paths for changes: 'docs', 'mkdocs.yml'
INFO    -  [16:34:55] Serving on http://127.0.0.1:8000/

Thanks,

Harel

@OldGrumpyViking
Copy link
Owner

Can you add a note to the history.md then i will merge and make a new release.

@harelwa harelwa force-pushed the do-not-capture-output branch from 8f6606c to c8ece5d Compare January 9, 2024 16:15
@harelwa
Copy link
Contributor Author

harelwa commented Jan 9, 2024

Can you add a note to the history.md then i will merge and make a new release.

done

@OldGrumpyViking OldGrumpyViking merged commit adba599 into OldGrumpyViking:main Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants