Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement visit() for sets and enums #48

Merged
merged 1 commit into from
Apr 16, 2024
Merged

implement visit() for sets and enums #48

merged 1 commit into from
Apr 16, 2024

Conversation

OleksandrKvl
Copy link
Owner

Fixes #45

@OleksandrKvl
Copy link
Owner Author

This deprecates 2 functions:

  • visit_set() because the new functionality covers the same case in a more generic way
  • enum_to_string() because it's not generic enough. Now users can write their own that produces either scoped-enum-style string like Color::Red or plain old Red.

@OleksandrKvl OleksandrKvl merged commit 0f25dd4 into main Apr 16, 2024
1 check passed
@OleksandrKvl OleksandrKvl deleted the OleksandrKvl/enum-set-visit-impl branch April 16, 2024 15:00
@OleksandrKvl OleksandrKvl mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support visit() for sets and enums
1 participant
@OleksandrKvl