Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csstudio-2781: Replace remarkable with markdown-it #170

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

maxfrederiksen-ess
Copy link
Collaborator

Summary of Changes

  • Fixes bug in ticket
  • Uses new more maintained lib (remarked last published 5 years ago)
  • Cleans up code and removes need to imageProcess script

Useful places to test:

  • Preview of new log entry in entry editor
  • Preview in log details view
  • Title, description in LHS drawer aka list view

Copy link
Member

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes bug, but what about all these warnings:

Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/decode.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/decode.ts'

Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/decode_codepoint.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/decode_codepoint.ts'

Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/encode.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/encode.ts'

Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/escape.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/escape.ts'

Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/decode-data-html.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/decode-data-html.ts'

Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/decode-data-xml.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/decode-data-xml.ts'

Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/encode-html.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/encode-html.ts'

Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/index.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/index.ts'

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

WARNING in ./node_modules/markdown-it/node_modules/entities/lib/esm/decode.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/decode.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/decode.ts'

WARNING in ./node_modules/markdown-it/node_modules/entities/lib/esm/decode_codepoint.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/decode_codepoint.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/decode_codepoint.ts'

WARNING in ./node_modules/markdown-it/node_modules/entities/lib/esm/encode.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/encode.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/encode.ts'

WARNING in ./node_modules/markdown-it/node_modules/entities/lib/esm/escape.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/escape.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/escape.ts'

WARNING in ./node_modules/markdown-it/node_modules/entities/lib/esm/generated/decode-data-html.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/decode-data-html.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/decode-data-html.ts'

WARNING in ./node_modules/markdown-it/node_modules/entities/lib/esm/generated/decode-data-xml.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/decode-data-xml.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/decode-data-xml.ts'

WARNING in ./node_modules/markdown-it/node_modules/entities/lib/esm/generated/encode-html.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/encode-html.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/generated/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/generated/encode-html.ts'

WARNING in ./node_modules/markdown-it/node_modules/entities/lib/esm/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/index.ts' file: Error: ENOENT: no such file or directory, open '/Users/georgweiss/projects/olog-es-web-client/node_modules/markdown-it/node_modules/entities/lib/esm/https:/raw.githubusercontent.com/fb55/entities/61afd4701eaa736978b13c7351cd3de9a96b04bc/src/index.ts'

@maxfrederiksen-ess
Copy link
Collaborator Author

@georgweiss I'm quite certain it has something to do with CRA: facebook/create-react-app#11752
I have created a ticket already for moving over to Vite, CRA is deprecated. CRA also doesn't allow us any control over the webpack file etc.

We recently did this move in CE and think it will build a better foundation for the project.

@maxfrederiksen-ess maxfrederiksen-ess merged commit 64a840b into main Dec 9, 2024
3 of 6 checks passed
@maxfrederiksen-ess maxfrederiksen-ess deleted the CSSTUDIO-2781 branch December 9, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants