Fix #4720 and unit tests #4721
Closed
Fix #4720 and unit tests #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidusjar
reviewed
Aug 9, 2022
| @@ -25,7 +24,6 @@ public class Metadata | |||
| public string primaryExtraKey { get; set; } | |||
| public string parentRatingKey { get; set; } | |||
| public string grandparentRatingKey { get; set; } | |||
| public string guid { get; set; } | |||
There was a problem hiding this comment.
We cannot do this. This will break the Plex Integration.
We rely on the guid property.
|
This is a problem, i've not looked into the best solution yet, it's probably combining the models rather than removing a property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4720 and 1 unit test that seems to be off