Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing benchmarking #337

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Preprocessing benchmarking #337

merged 11 commits into from
Sep 21, 2023

Conversation

xingzhongyu
Copy link
Collaborator

@xingzhongyu xingzhongyu commented Sep 9, 2023

Added modal prediction dataset;
Limit the number of features extracted in construct_enhanced_feature_graph in dance/transforms/graph/scmogcn_graph.py;
The extraction of idx in the get_feature method in dance/data/base.py is restricted to provide slices within the number of features.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xingzhongyu, thanks for the PR! Could you provide a bit more context about why this edit (targs[1]) is necessary? From my understanding, targs is the of gene indexs to hold out, and targs[1] would be the second gene index to holdout. So I'm a bit confused about the reason for this change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the loop uses enumerate, the resulting tuple needs to be taken out of the following content, otherwise report an error

Copy link
Collaborator

@RemyLau RemyLau Sep 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xingzhongyu could you help make some preliminary efforts to migrate the current download functions for the imputation dataset to use the downloading utilities in dance/utils/download.py like in the clustering dataset class? Imputation dataset is currently the only dataset that uses wget and curl (for historical reasons that are no longer relevant now).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I will finish the task in this week

@RemyLau RemyLau merged commit b206097 into main Sep 21, 2023
@RemyLau RemyLau deleted the preprocessing_benchmarking branch September 21, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants