Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 47 #49

Closed
wants to merge 15 commits into from
Closed

upgrade to 47 #49

wants to merge 15 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 7, 2023

Warning: obnoxiously large PR

don't need to use this exact technique, but I think it will be easier to work with this way.

We had to achieve the combined goals of:

  • upgrade to 47
  • remove spm and cosmoscmd
  • rebuild protos

When revieiwing the code, I found dependency relationships between omniflixhub and onft and marketplace, I think that
this will make for a more manageable developer experience -- checkout the x folder in github.com/osmosis-labs/oxmosis
for example -- all modules specific to osmosis are being developed there.

cheers! I hope to have this running later today or so :)

Note: there are some issues with this work:

  1. it does not perserve the commit history from the previous repositories. I think that we can find a way to do that, though. Certainly I didn't write all of this. (for example git merge --allow-unrelated-histories --merge-strategy --ours) (it's how I figure it ought to be done, please lmk)
  2. It restructures the code (I'd argue that this is a good thing because the modules and the like were tightly coupled to begin with)

Here's remaining tasks as I see them:

  • rebuild protobufs
  • ensure that protos build easily and cleanly
  • restructure tests
  • upgrade simulation

In total, it might be desirable for 4/20 to continue on with the currently planned v0.45.x release, and in that case, it's important that you use a fork of the cosmos-sdk since they're no longer doing maintenance work:

Juno is looking at maintaining an sdk 45 fork with patches like this and others applied.

@faddat
Copy link
Contributor Author

faddat commented Apr 7, 2023

I'm going to close this, and re-create from a notional labs fork so the rest of the team can help out.

@faddat faddat closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant