-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 47 #50
Closed
Closed
Upgrade to 47 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok, so, I will make some PR's into main.... containing the other code |
closing this PR as it is outdated now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: obnoxiously large PR
don't need to use this exact technique, but I think it will be easier to work with this way.
We had to achieve the combined goals of:
When revieiwing the code, I found dependency relationships between omniflixhub and onft and marketplace, I think that
this will make for a more manageable developer experience -- checkout the x folder in github.com/osmosis-labs/oxmosis
for example -- all modules specific to osmosis are being developed there.
cheers! I hope to have this running later today or so :)
Note: there are some issues with this work:
Here's remaining tasks as I see them:
In total, it might be desirable for 4/20 to continue on with the currently planned v0.45.x release, and in that case, it's important that you use a fork of the cosmos-sdk since they're no longer doing maintenance work:
CacheMultiStoreWithVersion
cosmos/cosmos-sdk#15683Juno is looking at maintaining an sdk 45 fork with patches like this and others applied.