Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update rocket surgery other #1120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update rocket surgery other #1120

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 20, 2023 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
Rocket.Surgery.MSBuild.CI (source) 1.1.5 -> 1.2.1 age adoption passing confidence nuget minor
Rocket.Surgery.MSBuild.SourceLink (source) 1.1.5 -> 1.2.1 age adoption passing confidence nuget minor
Rocket.Surgery.Nuke (source) 1.7.4 -> 1.8.36 age adoption passing confidence nuget minor
RocketSurgeonsGuild/actions v0.3.3 -> v0.3.13 age adoption passing confidence action patch

Release Notes

RocketSurgeonsGuild/MSBuild.Targets (Rocket.Surgery.MSBuild.CI)

v1.2.0

What's Changed
🚀 Features and 🔥 Enhancements
Public Dependencies
Other Items

Full Changelog: RocketSurgeonsGuild/MSBuild.Targets@v1.1.5...v1.1.6

RocketSurgeonsGuild/Nuke (Rocket.Surgery.Nuke)

v1.8.36

What's Changed

🐞 Bugs and Security Fixes
Public Dependencies
Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.35...v1.8.36

v1.8.35

What's Changed

🐞 Bugs and Security Fixes
Public Dependencies
Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.34...v1.8.35

v1.8.34

What's Changed

Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.33...v1.8.34

v1.8.33

What's Changed

Public Dependencies
Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.32...v1.8.33

v1.8.32

What's Changed

Public Dependencies
Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.31...v1.8.32

v1.8.31

What's Changed

Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.30...v1.8.31

v1.8.28

What's Changed

Public Dependencies
Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.27...v1.8.28

v1.8.26

What's Changed

Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.25...v1.8.26

v1.8.25

What's Changed

Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.24...v1.8.25

v1.8.24

What's Changed

Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.23...v1.8.24

v1.8.23

What's Changed

Public Dependencies
Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.22...v1.8.23

v1.8.22

What's Changed

Other Items

Full Changelog: RocketSurgeonsGuild/Nuke@v1.8.21...v1.8.22

v1.8.21

What's Changed

Other Items
  • ensure hus

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot enabled auto-merge (rebase) November 20, 2023 21:35
@github-actions github-actions bot added this to the v0.19.10 milestone Nov 20, 2023
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 3 times, most recently from f658aa1 to 0aa8e03 Compare November 20, 2023 23:21
@JoeRobich JoeRobich mentioned this pull request Nov 21, 2023
Closed
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 3 times, most recently from 9189f60 to 4425bbe Compare November 21, 2023 14:12
@renovate renovate bot changed the title chore(deps): update dependency rocket.surgery.nuke to v1.8.0 chore(deps): update dependency rocket.surgery.nuke to v1.8.1 Nov 21, 2023
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from 4425bbe to 72ce18b Compare November 21, 2023 20:00
@renovate renovate bot changed the title chore(deps): update dependency rocket.surgery.nuke to v1.8.1 chore(deps): update dependency rocket.surgery.nuke to v1.8.2 Nov 21, 2023
@renovate renovate bot changed the title chore(deps): update dependency rocket.surgery.nuke to v1.8.2 chore(deps): update dependency rocket.surgery.nuke to v1.8.3 Nov 21, 2023
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from 72ce18b to 24f9bbd Compare November 21, 2023 22:19
@renovate renovate bot changed the title chore(deps): update dependency rocket.surgery.nuke to v1.8.3 chore(deps): update dependency rocket.surgery.nuke to v1.8.4 Nov 22, 2023
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 3 times, most recently from c215f00 to 6f04dc8 Compare November 22, 2023 19:58
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 3 times, most recently from d60792a to b87ae18 Compare November 29, 2023 13:34
@renovate renovate bot changed the title chore(deps): update dependency rocket.surgery.nuke to v1.8.4 chore(deps): update dependency rocket.surgery.nuke to v1.8.5 Nov 29, 2023
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from b87ae18 to d021c2a Compare November 29, 2023 18:09
@renovate renovate bot changed the title chore(deps): update dependency rocket.surgery.nuke to v1.8.5 chore(deps): update dependency rocket.surgery.nuke to v1.8.6 Nov 29, 2023
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from d021c2a to 3e17d07 Compare November 29, 2023 23:25
@renovate renovate bot changed the title chore(deps): update dependency rocket.surgery.nuke to v1.8.6 chore(deps): update rocket surgery other Nov 29, 2023
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 2 times, most recently from 410572f to aed4a82 Compare December 3, 2023 23:43
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 4 times, most recently from 4ed5501 to 65d1143 Compare March 28, 2024 04:45
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from 65d1143 to 65b5dc2 Compare April 14, 2024 04:25
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 3 times, most recently from 173b9f3 to a46b983 Compare April 30, 2024 13:27
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from a46b983 to 3122717 Compare May 2, 2024 02:03
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from 3122717 to 5ac2741 Compare May 12, 2024 04:08
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 2 times, most recently from 63de2a2 to c01f07c Compare May 23, 2024 04:22
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 3 times, most recently from ece801a to 8eccf80 Compare June 3, 2024 18:40
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from 8eccf80 to 297137b Compare June 15, 2024 19:12
@manandre
Copy link
Contributor

The "default.runsettings could not be found" issue is now fixed.
Unfortunately, the build is also blocked by some NRE for windows and macos environments.

Object reference not set to an instance of an object.

As I do not reproduce the issue locally, without any additional clue(s), like a call stack, it will be difficult to identify then fix the issue here.
@JoeRobich Is there a way to get a call stack for this exception?

@manandre manandre mentioned this pull request Jun 16, 2024
Draft
@manandre
Copy link
Contributor

I have managed to add some verbose logging, what reveals the NRE call stack:

System.NullReferenceException: Object reference not set to an instance of an object.
   at Rocket.Surgery.Nuke.ContinuousIntegration.PrintBuildVersionAttribute.OnBuildInitialized(IReadOnlyCollection`1 executableTargets, IReadOnlyCollection`1 executionPlan) in /_/src/Nuke/ContinuousIntegration/PrintBuildVersionAttribute.cs:line 23
   at Nuke.Common.Utilities.Collections.EnumerableExtensions.ForEach[T](IEnumerable`1 enumerable, Action`1 action) in /_/source/Nuke.Utilities/Collections/Enumerable.ForEach.cs:line 20
   at Nuke.Common.NukeBuild.ExecuteExtension[TExtension](Expression`1 action)
   at Nuke.Common.Execution.BuildManager.Execute[T](Expression`1[] defaultTargetExpressions)

The history of the PrintBuildVersionAttribute class shows that a nullability check has been (intentionally?) removed.
For an unknown reason, the gitversion is not correctly computed on windows and macos platforms:

Building version null of LSP (Release) using version 7.0.6 of Nuke

Should we:

  • analyze why the gitversion is not correctly computed?
  • open an issue on the RSG/Nuke repo to tolerate null gitversion?

@JoeRobich What do you recommend?

@manandre
Copy link
Contributor

The issue with GitVersion.Tool may be related to nuke-build/nuke#1344
I propose to wait for a fix before investigating further.

@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 2 times, most recently from 4ad1012 to cf62f58 Compare June 29, 2024 00:08
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from cf62f58 to 76fe118 Compare July 16, 2024 02:20
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from 76fe118 to 3d1e6da Compare September 5, 2024 12:42
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 2 times, most recently from 0bf6f23 to 26620f7 Compare October 5, 2024 06:49
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch 2 times, most recently from fc6c838 to f7184d7 Compare October 10, 2024 00:35
@renovate renovate bot force-pushed the renovate/rocket-surgery-other branch from f7184d7 to bfe4610 Compare November 14, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.19.10
Development

Successfully merging this pull request may close these issues.
1 participant
@manandre