Merge pull request #2172 from OmniSharp/avoid-null-reference

Defend against null value in BuildErrorEventArgs
OmniSharp · Jun 7, 2021 · 5b7fe24 · 5b7fe24
2 parents c852b27 + caaba64
commit 5b7fe24
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/OmniSharp.MSBuild/Logging/MSBuildDiagnostic.cs b/src/OmniSharp.MSBuild/Logging/MSBuildDiagnostic.cs
@@ -40,7 +40,7 @@ public static MSBuildDiagnostic CreateFrom(Microsoft.Build.Framework.BuildErrorE
 
             // https://github.com/dotnet/msbuild/blob/v16.8.3/src/Tasks/Resources/Strings.resx#L2155-L2158
             // for MSB3644, we should print a different message on Unix because the default one is Windows-specific
-            if (args.Code.Equals("MSB3644", StringComparison.OrdinalIgnoreCase))
+            if (args.Code?.Equals("MSB3644", StringComparison.OrdinalIgnoreCase) == true)
             {
                 // https://github.com/dotnet/msbuild/issues/5820
                 // older versions of MSBuild incorrectly treat 'net5.0'/'net6.0' moniker as ".NETFramework,Version=v5.0/6.0"