-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omnisharp VS Code Issue 1814 Fix #1007
Changes from 1 commit
868c002
debcfec
71a318b
e74060a
f8e6896
94459ae
c33df39
cd8954f
978efe6
f7ac87b
ace2701
9a1e814
9445b4b
c91c3f0
fff464b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,7 +153,7 @@ private int Foo(int one, int two, int three) | |
} | ||
|
||
[Fact] | ||
public async Task SignatureHelpforAttCtorSingleArg() | ||
public async Task SignatureHelpforAttCtorSingleParam() | ||
{ | ||
const string source = | ||
@"using System; | ||
|
@@ -192,7 +192,7 @@ public MyTestAttribute(int value) | |
Assert.Equal("int value", signature.Parameters.ElementAt(0).Label); | ||
} | ||
[Fact] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing blank line before method. Should be between close brace and |
||
public async Task SignatureHelpforAttCtorMultipleArg() | ||
public async Task SignatureHelpforAttCtorMultipleParam() | ||
{ | ||
const string source = | ||
@"using System; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this pass? It doesn't look like there's a "$$" anywhere in the markup? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My bad, I see it. Anyway, it seems like the test is called "MultipleParam", but you're only testing in the first parameter position. |
||
|
@@ -225,6 +225,36 @@ public MyTestAttribute(int value1,double value2) | |
Assert.Equal("double value2", signature.Parameters.ElementAt(1).Label); | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unnecessary blank line |
||
[Fact] | ||
public async Task SignatureHelpforAttCtorNoParam() | ||
{ | ||
const string source = | ||
@"using System; | ||
[MyTest($$)] | ||
public class TestClass | ||
{ | ||
public static void Main() | ||
{ | ||
} | ||
} | ||
public class MyTestAttribute : Attribute | ||
{ | ||
int value1; | ||
double value2; | ||
public MyTestAttribute() | ||
{ | ||
this.value1 = 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can delete all the "value1" and "value2" related stuff since this test doesn't use them. |
||
this.value2 = 2; | ||
} | ||
}"; | ||
var actual = await GetSignatureHelp(source); | ||
Assert.Single(actual.Signatures); | ||
Assert.Equal(0, actual.ActiveParameter); | ||
Assert.Equal(0, actual.ActiveSignature); | ||
Assert.Equal("MyTestAttribute", actual.Signatures.ElementAt(0).Name); | ||
Assert.Empty(actual.Signatures.ElementAt(0).Parameters); | ||
} | ||
|
||
[Fact] | ||
public async Task ActiveParameterIsBasedOnComma2() | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that we not abbreviate "attribute".