Add back code that sets MSBuildSDKsPath environment variable for each project #1021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, it seems that there are some reliability issues with the MSBuild SDK Resolvers that we haven't gotten to the bottom of yet. So, I'm adding back code to set the
MSBuildSDKsPath
environment variable per project based on running thedotnet
in that project's directory.This should address issues like dotnet/vscode-csharp#1849 and dotnet/vscode-csharp#1846.
Note that this is not a long term solution. It will work for now, but there are several future concerns that we need to be mindful of:
dotnet --info
output changes such thatBase Path
no longer appears in the text, this will break and need to be updated.cc @nguerrera, @livarcocc