Update OmniSharp to latest MSBuild #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates OmniSharp with the latest MSBuild binaries. Recent performance changes for MSBuild now require NuGet.Build.Tasks, which requires a set of NuGet binaries be included as well. Because the versions of these NuGet binaries might be different (actually, they *are* different) than the binaries that OmniSharp uses, there's a bit of duplication.
DustinCampbell
requested review from
rchande,
jonsequitur,
david-driscoll and
filipw
filipw
approved these changes
Apr 6, 2018
rchande
approved these changes
Apr 6, 2018
'BypassFrameworkInstallChecks' allows builds to skip a particularly hacky check in the GetReferenceAssemblyPaths task. This hack affects projects that target a .NET Framework version less than 4.0. Essentially, the hack tries to load a certain assembly from the GAC to "guarantee" that .NET Framework 3.5 SP1 is installed (an old case added specifically for WPF projects). However, we don't include that assembly in our Mono package. So, many Unity projects end up failing the check because they often target much early .NET Framework versions. We can fix that by just skipping the check, which isn't really necessary when we're running on Mono.
|
I've tested a number of scenarios with the new MSBuild, including Xamarin Forms (with iOS and Android), Unity and .NET Core 2.1 (KestrelHttpServer). All are working well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates OmniSharp with the latest MSBuild binaries. Recent performance changes for MSBuild now require NuGet.Build.Tasks, which requires a set of NuGet binaries be included as well. Because the versions of these NuGet binaries might be different (actually, they are different) than the binaries that OmniSharp uses, there's a bit of duplication.