Initialize CSX file watcher also when no CSX files are available at startup #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not provided if no CSX files existed at the moment OmniSharp was started
DustinCampbell
approved these changes
Jun 1, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,9 @@ | |||
| # Changelog | |||
| All changes to the project will be documented in this file. | |||
|
|
|||
| ## [1.32.0] - not yet released | |||
| * Fixed a bug where lanugage services for newly created CSX files were not provided if no CSX files existed at the moment OmniSharp was started ([#1199](https://github.com/OmniSharp/omnisharp-roslyn/issues/1199), PR: [#1210](https://github.com/OmniSharp/omnisharp-roslyn/pull/1210)) | |||
There was a problem hiding this comment.
typo: "lanugage" -> "language"
tests/TestUtility/DisposableFile.cs
Outdated
|
|
||
| namespace TestUtility | ||
| { | ||
| public class DisposableFile : IDisposable |
There was a problem hiding this comment.
Is there anything here that can be shared with the code in TestProject?
There was a problem hiding this comment.
good point, I think I will remove this completely, and instead allow a new file to be added to an existing TestProject. If the project was shadowcopied, the file will disappear with it, and it if it wasn't we will delete it during the disposal of TestProject. This will keep all I/O clean up operations in TestProject which is our unit of work in these tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1199
At the moment we only initialized CSX file watcher (reacting to new or removed files) when there were any CSX files discovered at startup, which was mentioned and discussed in #1199
This PR fixes that, and we also listen when no CSX files are available at startup, so as soon as you add your first one, language services light up.
This whole change would have been a single line https://github.com/OmniSharp/omnisharp-roslyn/compare/master...filipw:bugfix/1199?expand=1#diff-ed5a3c116a19423c18b1e630f80455b9R70 but I took a liberty to rationalize some of the code around scripting.
For example renamed
ScriptHelpertoScriptProjectProvider, and extracted aScriptContextandScriptContextProviderfrom the spaghetti project system. While this made the diff rather big (sorry), it shouldn't affect anything.Finally, ignored the ordering on one of the flaky tests (#1193 (review)) and added a test for this new watching feature.