Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Roslyn for Preview 7 #1534

Merged
merged 7 commits into from
Jun 28, 2019
Merged

Conversation

filipw
Copy link
Member

@filipw filipw commented Jun 28, 2019

branched from #1533 where I fixed editorconfig to adapt to dotnet/roslyn#27942

@filipw
Copy link
Member Author

filipw commented Jun 28, 2019

this now passes on Windows but has some weird Mono problem on linux/mac 😩

@filipw
Copy link
Member Author

filipw commented Jun 28, 2019

cc @akshita31

@filipw
Copy link
Member Author

filipw commented Jun 28, 2019

green 🍏

Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@david-driscoll david-driscoll merged commit 9aa3f7c into OmniSharp:master Jun 28, 2019
@filipw filipw mentioned this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants