Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed AllowUnsafe regression #1567

Merged
merged 4 commits into from
Jul 22, 2019
Merged

fixed AllowUnsafe regression #1567

merged 4 commits into from
Jul 22, 2019

Conversation

filipw
Copy link
Member

@filipw filipw commented Jul 22, 2019

accidentally, AllowUnsafe also behaved like TreatWarningsAsErrors 😂
fixes #1565

@david-driscoll david-driscoll merged commit c88a425 into OmniSharp:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-driscoll david-driscoll david-driscoll approved these changes

@rchande rchande Awaiting requested review from rchande

@bjorkstromm bjorkstromm Awaiting requested review from bjorkstromm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AllowUnsafeBlocks=true makes all warning to error from v1.33.0
2 participants
@filipw @david-driscoll