Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test discovery and NoBuild option to test requests #1719

Merged
merged 12 commits into from
May 19, 2020
Merged

Add test discovery and NoBuild option to test requests #1719

merged 12 commits into from
May 19, 2020

Conversation

Samirat
Copy link
Contributor

@Samirat Samirat commented Feb 23, 2020

More info about this in the related VSCode extension PR:
dotnet/vscode-csharp#3601

This adds

  1. A DiscoverTests request, which lets you get info for all tests in an assembly
  2. A NoBuild option for test requests, which lets you run/debug tests without always building first

There is a separate PR with just the runsettings additions.

@dnfclas
Copy link

dnfclas commented Mar 10, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

JoeRobich
JoeRobich approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one questionable change.

package-lock.json Outdated Show resolved Hide resolved
@JoeRobich
Copy link
Member

@Samirat Thanks!

@JoeRobich JoeRobich merged commit 32cfc54 into OmniSharp:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Samirat @dnfclas @JoeRobich @filipw