Added asnychronous test completed events #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoeRobich I've had this one hanging for a while, can you review or mention someone to review |
JoeRobich
reviewed
Aug 12, 2020
JoeRobich
approved these changes
Aug 12, 2020
|
@david-driscoll @mholo65 @filipw Anyone have any additional thoughts? |
david-driscoll
approved these changes
Aug 13, 2020
|
@JoeRobich Doesn't look like I can merge this myself. |
|
@Samirat Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds events whenever a test is completed. Without it, you have to wait for all the results to be available before you get any feedback. When running long suites of tests, this makes it a lot more usable.
All
TestResultobjects are already processed as events by the VS Code extension, so I don't think any changes are necessary to the vscode extension. This does mean it'll see them twice, once from the asynchronous event and once from the RunTestResponse, but I don't think this has any bad effects.