-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the Hover LSP provider to use the new quickinfo service #1870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Thanks @333fred |
I'm migrating my client to use LSP with OmniSharp-Roslyn. EDIT: Ah, just figured it out! /// an integer, or something
private int an_int; But now the docstring has to be wrapped in |
@david-driscoll this does what it says on the tin. Hopefully this will be another thing that we can get working in vscode. I'm unsure what the
Range
in LSP represents here, though: is it supposed to be full range of the thing being hovered over? If so, I'm not sure if we actually want to implement that: I'm used to highlighting either getting every instance of a thing, or not highlighting it at all. If we do want to implement that, though, it would be very straightforward to add, as QuickInfo already has the info.Fixes #1806.