-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated build tool version for NET 5 RC2 #1971
Conversation
please update the tests too - see #1953 for reference |
I updated the MSBuild pacakging so that all platforms now use the "net472" resolvers. |
@JoeRobich I am not sure I get the change. so it first copies the Mono ref assemblies from global Mono but then overwrites whatever it can from Nuget, correct? |
@filipw Yes, it is doing the same thing that master is presently doing. I just refactored so that the common steps are more apparent. Since some targets and ref assemblies are needed from Mono's MSBuild, we copy those over first, since they are not in the MSBuild NuGets. We then overwrite with the version of MSBuild we want to ship with from the NuGet. I can update the list of MSBuild runtime targets and props so that we are only copying over what isn't present in the NuGets. The actual change is that we use the "net472" resolvers on all platforms as RC2 doesn't ship with "netstandard2.0" resolvers. |
…nisharp-roslyn into update-build-tools-rc2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
shall we upgrade Roslyn too? |
Sure. Let me see what we are likely shipping in 16.8 Preview 4. |
@JoeRobich did I miss more entries in that xml? |
No description provided.