Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Roslyn to 3.8.0-4.20503.2 #1974

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Bump Roslyn to 3.8.0-4.20503.2 #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<MSBuildPackageVersion>16.6.0</MSBuildPackageVersion>
<NuGetPackageVersion>5.2.0</NuGetPackageVersion>
<RoslynPackageVersion>3.8.0-3.20451.2</RoslynPackageVersion>
<RoslynPackageVersion>3.8.0-4.20503.2</RoslynPackageVersion>
<XunitPackageVersion>2.4.1</XunitPackageVersion>
</PropertyGroup>

Expand Down
10 changes: 2 additions & 8 deletions tests/OmniSharp.Roslyn.CSharp.Tests/CodeActionsWithOptionsFacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ public class Class1 : NewBaseType
{
}";

// TODO: this refactoring was renamed to 'Extract base class...' in latest Roslyn
// it needs to be updated accordingly when we pull in new Roslyn build
// https://github.com/dotnet/roslyn/commit/2d98f81de3908f39cd582d3de0c51c738c558700
var response = await RunRefactoringAsync(code, "Pull member(s) up to new base class...");
var response = await RunRefactoringAsync(code, "Extract base class...");
AssertUtils.AssertIgnoringIndent(expected, ((ModifiedFileResponse)response.Changes.First()).Buffer);
}

Expand All @@ -65,10 +62,7 @@ public class Class1 : NewBaseType
public void Method() { }
}";

// TODO: this refactoring was renamed to 'Extract base class...' in latest Roslyn
// it needs to be updated accordingly when we pull in new Roslyn build
// https://github.com/dotnet/roslyn/commit/2d98f81de3908f39cd582d3de0c51c738c558700
var response = await RunRefactoringAsync(code, "Pull member(s) up to new base class...");
var response = await RunRefactoringAsync(code, "Extract base class...");
AssertUtils.AssertIgnoringIndent(expected, ((ModifiedFileResponse)response.Changes.First()).Buffer);
}

Expand Down