Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove format on newline #2053

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Conversation

333fred
Copy link
Contributor

@333fred 333fred commented Dec 27, 2020

Roslyn APIs were not intended to handle this case and doing so can cause very odd behavior, such as extraneous newlines being added for malformed code and/or automatic indentation being removed, making for a frustrating experience. Superscedes #2051.

…ded to handle this case and doing so can cause very odd behavior, such as extraneous newlines being added for malformed code and/or automatic indentation being removed, making for a frustrating experience.
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! looks good to me

@333fred
Copy link
Contributor Author

333fred commented Jan 4, 2021

@filipw is this waiting for anything else?

@filipw filipw merged commit 35f7b29 into OmniSharp:master Jan 4, 2021
@filipw
Copy link
Member

filipw commented Jan 4, 2021

no 😀

@333fred 333fred deleted the remove-newline-format branch January 4, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants