OmniSharpDocumentSymbolHandler.cs: a fix for a crash in 'textDocument/documentSymbol` LSP request #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/documentSymbol' The NRE may happen when OS.R.CS.Services.SStructre.CodeStructureService returns a null during the time when projects are still being loaded but LSP client already sends queries for symbol info under cursor. Related to OmniSharp#2141
|
Thanks a lot - I think we should better solve it for non-LSP endpoint as well. I opened #2148 which should supersede this PR here. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NRE may happen when OS.R.CS.Services.Structure.CodeStructureService
returns a null during the time when projects are still being loaded but
LSP client already sends queries for symbol info under cursor.
Reported in and should fix #2141