Use the Microsoft.Build.Locator package for discovery #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
approved these changes
Jun 20, 2021
There was a problem hiding this comment.
This looks like a terrific idea to me 👏
thank you for porting this. one thing that occurred to me is that it may change the meaning of "useglobalmono": "always".
Perhaps we could consider adding a flag to be able to force the Mono instance provider with highest priority
@filipw hmm.. This should only replace the VS and DevConsole providers. The new instance provider shouldn't return instances on non-Windows platforms. Should I change the check to not return instances on Mono platforms? |
|
ugh sorry I missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought this might be a good change to backport from the vnext branch.