Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for <WarningsAsErrors>nullable</WarningsAsErrors> #2406

Merged
merged 4 commits into from
Jun 4, 2022

Conversation

filipw
Copy link
Member

@filipw filipw commented Jun 3, 2022

Fixes #2292

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hate that it is a list we need to maintain. Hopefully dotnet/roslyn#49392 will get resolved in a way that we can remove this.

Copy link
Contributor

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an API request on Roslyn to make this API public. I'm ok copying the list as a temporary solution, but I'm not comfortable using it long term.

@filipw
Copy link
Member Author

filipw commented Jun 4, 2022

yes, makes sense

@filipw filipw merged commit 69b4123 into master Jun 4, 2022
@filipw filipw deleted the bugfix/nullable-errors branch June 4, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nulllable warnings do not show as errors with WarningsAsErrors
3 participants