[WIP] Updating MSBuild for the future #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
force-pushed
the
msbuild-update-windows
branch
5 times, most recently
from
5c4e1f2
to
8d4220e
Compare
david-driscoll
changed the title
| @@ -330,7 +350,13 @@ private void UpdateSourceFiles(Project project, IList<string> sourceFiles) | |||
| continue; | |||
| } | |||
|
|
|||
| // If not, add a new document. | |||
| // If the source file doesn't exist on disk, don't try to add it. | |||
| if (!File.Exists(sourceFile)) | |||
There was a problem hiding this comment.
I wonder if this is needed? Many editors atom/vscode don't require you to save a file to start writing in the file.
It would be great if we could offer a nice editing experience even if the file doesn't yet exist. Though that then has it's own set of problems... that maybe we shouldn't dive into just yet.
There was a problem hiding this comment.
This is avoiding a crash below. Unless atom/vscode show you a view of your project, I'm not sure it matters whether we do something fancy in the workspace. This is the scenario where VS would show you a little warning icon in the solution explorer.
DustinCampbell
force-pushed
the
msbuild-update-windows
branch
2 times, most recently
from
4721638
to
44b1c28
Compare
…be copied to output
DustinCampbell
force-pushed
the
msbuild-update-windows
branch
from
44b1c28
to
4c6ba03
Compare
|
Closing this PR. We'll do the work over in the new-msbuild branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
These are my current changes to support MSBuild 15.0 and run OmniSharp on an embedded Mono. As mentioned in #666, there's a fair amount of work to sort out how OmniSharp will acquire its Mono and MSBuild payloads, so this can't be simply merged.