Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the default ScriptMetadataResolver for scripts #721

Merged
merged 1 commit into from
Jan 6, 2017
Merged

use the default ScriptMetadataResolver for scripts #721

merged 1 commit into from
Jan 6, 2017

Conversation

filipw
Copy link
Member

@filipw filipw commented Jan 5, 2017 •
edited
Loading

Fixes #702.

This allows OmniSharp to support intellisense when GAC reference is used. i.e. instead of:

#r "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6\System.Web.dll"

we can use:

#r "System.Web"

This is in line with the default CSI behavior, which supports GAC references.

@filipw
Copy link
Member Author

filipw commented Jan 5, 2017

in action:

@filipw filipw requested a review from DustinCampbell January 5, 2017 08:30
@filipw
Copy link
Member Author

filipw commented Jan 6, 2017

thanks - let's punch this in then!

@filipw filipw merged commit c6e3791 into OmniSharp:dev Jan 6, 2017
@filipw filipw deleted the bugfix/702 branch January 6, 2017 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipw @DustinCampbell