Watch for changes in omnisharp.json #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
force-pushed
the
feature/omnisharp-watch
branch
from
296a681 to
660cdfc
Compare
|
related issue: (see comment 1) #366 (comment) |
src/OmniSharp.Host/Startup.cs
Outdated
| @@ -20,6 +20,7 @@ | |||
| using OmniSharp.Services.FileWatching; | |||
| using OmniSharp.Stdio.Logging; | |||
| using OmniSharp.Stdio.Services; | |||
| using System.IO; | |||
There was a problem hiding this comment.
sort order? Shouldn't System namespaces be on top?
There was a problem hiding this comment.
yes, I deleted it now as it wasn't even used; it crept in here because of some code that I ended up ultimately removing
it deals with the strongly typed OmnisharpOptions so at the moment that's formatting only |
|
related issue: dotnet/vscode-csharp#1290 (comment) |
|
one more related issue: dotnet/vscode-csharp#1080 |
DustinCampbell
approved these changes
Mar 26, 2017
davidfowl
reviewed
Mar 26, 2017
| @@ -49,7 +49,7 @@ public Startup(IOmniSharpEnvironment env) | |||
| new PhysicalFileProvider(env.Path), | |||
| "omnisharp.json", | |||
| optional: true, | |||
| reloadOnChange: false); | |||
| reloadOnChange: true); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces live change tracking in
omnisharp.json. There are a couple of issues open for that, will attach them to this PR when I locate them 😄At the moment changes in formatting settings in
omnisharp.jsonare only read by OmniSharp at startup - so if you change anything you need to restart the server to have them take effect which is not an ideal experience.Note that we do not roll out a file watcher by hand, but rather rely on change tracking capabilities of
Microsoft.Extensions.Configuration. On OmniSharp side, technically, the way it's implemented, is that we let each of ourIWorkspaceOptionsProviderrun as soon as the configuration change is reported.Here is the change in action:
