Handle package reference version ranges in .csproj files #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
reviewed
Apr 6, 2017
| @@ -5,21 +5,20 @@ namespace OmniSharp.MSBuild.ProjectFile | |||
| { | |||
| public class PackageReference : IEquatable<PackageReference> | |||
| { | |||
| public PackageIdentity Identity { get; } | |||
| public PackageDependency Identity { get; } | |||
There was a problem hiding this comment.
maybe you'd want to go from public PackageIdentity Identity { get; } to public PackageDependency Dependency { get; } instead?
There was a problem hiding this comment.
Yes -- thanks!
filipw
reviewed
Apr 6, 2017
| { | ||
| NuGetVersion version; | ||
| if (NuGetVersion.TryParse(propertyValue.Trim(), out version)) | ||
| if (VersionRange.TryParse(propertyValue.Trim(), out var version)) |
There was a problem hiding this comment.
maybe I'm weird but doesn't it strike you as a bit inconsistent that in the same namespace they'd have two different naming styles - NuGetVersion and VersionRange (used for, well, NuGetVersions)?
There was a problem hiding this comment.
There's a bunch of them: NuGetVersion, SemanticVersion, VersionRange, FloatRange. They're all in NuGet.Versioning. NuGetVersion is a specific version, used for package identity. A range wouldn't be suitable for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I did the initial punch through to get package references working in .csproj, I failed to account for version ranges. This should address the unresolved dependencies warnings reported in #795.