Fixed GoToMetadata in CSX #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Apr 19, 2017
| // we will use temporary project to hold metadata documents | ||
| var metadataProject = project.IsSubmission ? project.Solution.AddProject("metadataTemp", "metadataTemp.dll", LanguageNames.CSharp). | ||
| WithCompilationOptions(project.CompilationOptions). | ||
| WithMetadataReferences(project.MetadataReferences) : project; |
There was a problem hiding this comment.
Tiny, tiny, tiny nit: This might be more readable if formatted like so:
C#
var metadataProject = project.IsSubmission
? project.Solution.AddProject("metadataTemp", "metadataTemp.dll", LanguageNames.CSharp)
.WithCompilationOptions(project.CompilationOptions)
.WithMetadataReferences(project.MetadataReferences)
: project;
| @@ -136,7 +136,12 @@ public void AddFilesToWorkspace(params TestFile[] testFiles) | |||
| this.Workspace, | |||
| "project.json", | |||
| new[] { "dnx451", "dnxcore50" }, | |||
| testFiles); | |||
| testFiles.Where(f => f.FileName.EndsWith(".cs", StringComparison.CurrentCultureIgnoreCase)).ToArray()); | |||
There was a problem hiding this comment.
Do we want CurrentCulture? Should that be OrdinalIgnoreCase
There was a problem hiding this comment.
ah sure, I just picked "that long thing" from intellisense without thinking twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #755
At the moment Go To Metadata doesn't work in CSX files. The reason is, in the current implementation of metadata handling on the server, a metadata-document was added to current project. This is not allowed in
submissiontype projects (which are used for CSX files), as they can only have one root syntax tree, cannot have namespaces etc. - and an ugly unhandled exception was thrown instead. To fix this, we actually create a temporary project (which is thrown away) for CSX metadata navigation.The fix doesn't affect the original code path so there is no risk merging this. However similar implementation (a temporary project) could also be considered there, because at the moment we flood the current project with new documents every time metadata is accessed. I left it intact because perhaps there was some reason to implement it like that?
I also added GoToMetadata tests for CSX to validate this fix.