-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get NUnit test running/debugging working #834
Conversation
<?xml version="1.0" encoding="utf-8"?> | ||
<configuration> | ||
<packageSources> | ||
<add key="AppVeyor NUnit CI Feed" value="https://ci.appveyor.com/nuget/nunit" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but you don't need this line/feed unless you want to pull in pre-release versions of the NUnit Framework. The adapter PR only uses the Engine and Adapter feeds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as there's an NUnitTestAdapter on nuget.org that we can use, I'll just delete this file.
// When it does, the NUnitTestProject should be updated and the tests below re-enabled. | ||
|
||
//[Fact] | ||
[Fact] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing NUnit with xUnit, ironic 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, NUnit doesn't work yet, so...
Looks good. At my end, I will push an update to the adapter to handle null |
Thank you very much @DustinCampbell and @rprouse ! Noob's Question: How can I use this version of omni-sharp? 😄 |
@bernardbr: I'll be producing a new omnisharp-vscode beta later today with this fix. |
Ok @DustinCampbell |
Alright. CI passed again. I'm going to go ahead and merge. |
@bernardbr I fixed this in the NUnit adapter also with nunit/nunit3-vs-adapter@d345c72 and the NuGet package 4.0.0-ci-00455-pr-313 and newer should work without these fixes. |
Hello @rprouse! Thanks! ##Editing |
@bernardbr It isn't working for me either. I am attempting to debug and will report back. |
Try the 1.10.0-beta1 release of C# for VS Code I created last night. Follow these steps Installing Beta Releases. |
@DustinCampbell your fix is working. I just can't figure out why my fix isn't working and I am having trouble debugging with all the layers. What is troubling me is that I believe your fix confirmed my diagnosis that we weren't handling a null Is there anyway to get the callstack like you displayed in the issue without a debug compile? |
Not without a compile of OmniSharp without my change. That's not actually too big of a deal. I usually do it like so on Windows:
"omnisharp.path": "<path to your omnisharp folder>/OmniSharp/bin/Debug/net46/OmniSharp.exe"
|
Fixes dotnet/vscode-csharp#1434
This change updates the test manager to pass dummy
RunSettings
, which allows the latest NUnit alpha to work (the NUnit test adapter does not handle null RunSettings). In addition, this updates our NUnit test project to use the latest NUnitTestAdapter CI build and uncomments the NUnit tests. When there's an official NUnitTestAdapter release, we'll want to update the test project to reference that and get rid of its NuGet.config.cc @bernardbr and @rprouse