Expose MsBuild Configuration and Platform setting #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows choosing other (than default) MsBuild configuration, e.g. MsBuild:Configuration=Release MsBuild:Platform=x64, especially usable for projects that are not using default (AnyCPU) platforms. This relates to OmniSharp#202.
We don't have great test infrastructure for this yet. It's pretty close, but would require a bit of refactoring to pass in custom options when creating an OmniSharpTestHost. Eventually, I hope we can add an endpoint to support changing Configuration, Platform, and also TargetFramework. |
DustinCampbell
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows choosing other (than default) MsBuild configuration, e.g.
MsBuild:Configuration=ReleaseMsBuild:Platform=x64, especially usablefor projects that are not using default (AnyCPU) platforms.
This relates to #202.
P.S. Do we need to add some tests on that one? Or is there any other particular way to override Configuration/Platform planned?