Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for loading external code actions #887

Merged

Conversation

filipw
Copy link
Member

@filipw filipw commented Jun 7, 2017

This is a follow up to #848 which didn't have tests in it.

This PR:

  • contains a unit test for loading an external refactoring (it's an Add ConfigureAwait(false) refactoring)
  • introduces a binaries folder in the test-assets, which is exposed to test infrastructure. The folder contains a DLL with the aforementioned refactoring.
  • extends the test infrastructure to allow passing in custom configuration, which is then translated to OmnisharpOptions - this will be helpful in testing different states of the configuration

@filipw filipw force-pushed the feature/external-code-action-test branch from d4c1616 to 4add01b Compare June 7, 2017 11:04
Copy link
Contributor

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -12,13 +12,16 @@ public partial class TestAssets
public string OmniSharpSolutionPath { get; }
public string TestAssetsFolder { get; }
public string TestProjectsFolder { get; }
public string TestBinariesFolder { get; }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra blank line

@DustinCampbell DustinCampbell merged commit 4fab48f into OmniSharp:dev Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants