Fix solution parsing (again!) #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I'm expecting AppVeyor to fail initially due to the outage their experiencing around NuGet (http://status.appveyor.com/incidents/m2vdvw39kdk8). I'm currently tracking the incident there and will re-kick the CI once it's resolved. Also, I'm betting the OSX build will fail as it seems to time out a lot during US business hours. I'll kick it later if it does time out. |
david-driscoll
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that my recent change to use the MSBuild solution parsing API (for a second time) has broken Unity solutions. In this particular case, the MSBuild API throws if a solution file contains multiple projects with the same name, which is how Unity solutions are generated. Thanks to @Leopotam for reporting this issue!
The MSBuild API is much more restrictive about the format of a solution file than Visual Studio. I suppose that makes sense given that MSBuild can fail fast if a solution file is invalid. However, an IDE must be more resilient against faults. So, I've written a brand new solution parser from scratch. It is heavily derived from the parser in MSBuild.
Fixes dotnet/vscode-csharp#1645