-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fadeout based on roslyn tag 'unnecessary'. #2873
Fadeout based on roslyn tag 'unnecessary'. #2873
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2873 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 59 59
Lines 1570 1570
Branches 89 89
=======================================
Hits 1409 1409
Misses 149 149
Partials 12 12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2873 +/- ##
=======================================
Coverage 89.79% 89.79%
=======================================
Files 59 59
Lines 1588 1588
Branches 89 89
=======================================
Hits 1426 1426
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
This is ready for review @rchande @akshita31 Requires latest version of omnisharp-roslyn master branch and analyzers enabled. |
I would recommend to wait with this until there is official omnisharp-roslyn with the analyzers feature + that version is consumed by the C# extension. |
@savpek Is it possible to add a test for this ? |
Could @rchande @akshita31 check this out? It should be good to go and i use this at daily basis (custom build). I'd like to use this PR test infra with #3089 since i ended up refactor diagnostic provider there a bit and it's good point to add more tests for diagnostics 🙂 |
Looks good to me. Thanks @savpek |
@savpek Would you like to do another PR to add the changelog. |
@akshita31 changelog #3105 |
Changelog for #2873 (Fadeout)
Based on original PR #2646 from @akshita31
Requires OmniSharp/omnisharp-roslyn#1410 and OmniSharp/omnisharp-roslyn#1076 to be fully functional.
Without backend support (previous PR:s), this has few hard coding to fade most common situations without full blown analysis:(decided not to hard code anything at this point, requires analyzers.)With backend support (theres Roslynator package that fadeouts some additional items from image):
Theres some mapping when fadeout occurs because VSCode doesn't support 'hidden' with fadeout, so those items must be converted to hints or fadeout doesn't work on them.