Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for #2873 (Fadeout) #3105

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Changelog for #2873 (Fadeout) #3105

merged 3 commits into from
Jun 11, 2019

Conversation

savpek
Copy link
Contributor

@savpek savpek commented Jun 9, 2019

@savpek savpek mentioned this pull request Jun 9, 2019
Merged
rchande
rchande suggested changes Jun 10, 2019
View reviewed changes
CHANGELOG.md Outdated
@@ -12,6 +12,7 @@
## 1.20.0 (Not yet released)

* Updated the auto-generated launch.json to use new mechanism for starting web browser. For more information: https://aka.ms/VSCode-CS-LaunchJson-WebBrowser
* Fadeout support [#2873](https://github.com/OmniSharp/omnisharp-vscode/pull/2873)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Added support for fading unnecessary code and using statements"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@rchande
Copy link

rchande commented Jun 10, 2019

Thanks for the PR, I suggested a more informative phrasing.

@codecov
Copy link

codecov bot commented Jun 11, 2019 •
edited
Loading

Codecov Report

Merging #3105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3105   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files          59       59           
  Lines        1588     1588           
  Branches       89       89           
=======================================
  Hits         1426     1426           
  Misses        151      151           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a040a...c005997. Read the comment docs.

@rchande rchande merged commit 74090ae into dotnet:master Jun 11, 2019
@savpek savpek deleted the changelog-for-2873 branch June 11, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchande rchande rchande requested changes

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@savpek @rchande @filipw