Update to OmniSharp 1.37.0 #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
force-pushed
the
update-omnisharp-1.37.0
branch
from
0494826 to
3601445
Compare
filipw
reviewed
Aug 18, 2020
README.md
Outdated
| - Register FixAll commands for disposal ([#3984](https://github.com/OmniSharp/omnisharp-vscode/issues/3984), PR: [#3985](https://github.com/OmniSharp/omnisharp-vscode/pull/3985)) | ||
| - Include version matched target files with minimal MSBuild (PR: [omnisharp-roslyn#1895](https://github.com/OmniSharp/omnisharp-roslyn/pull/1895)) | ||
| - Fix lack of trailing italics in quickinfo (PR: [omnisharp-roslyn#1894](https://github.com/OmniSharp/omnisharp-roslyn/pull/1894)) | ||
| - Start moving omnisharp to directly using Roslyn's completion service (PR: [omnisharp-roslyn#1877](https://github.com/OmniSharp/omnisharp-roslyn/pull/1877)) |
There was a problem hiding this comment.
I think this is not yet relevant to the C# extension
There was a problem hiding this comment.
Good point. =) Looks like new completion will wait on https://github.com/dotnet/aspnetcore/issues/25008https://github.com/dotnet/aspnetcore/issues/2500
brettfo
approved these changes
Aug 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #3998 +/- ##
==========================================
- Coverage 85.97% 85.96% -0.02%
==========================================
Files 60 60
Lines 1854 1852 -2
Branches 215 214 -1
==========================================
- Hits 1594 1592 -2
Misses 200 200
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JoeRobich
force-pushed
the
update-omnisharp-1.37.0
branch
from
5a57303 to
aca41f4
Compare
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.