Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename not apply #1

Closed
wants to merge 246 commits into from
Closed

rename not apply #1

wants to merge 246 commits into from

Conversation

333fred
Copy link
Owner

@333fred 333fred commented Oct 21, 2020

JoeRobich and others added 29 commits August 19, 2020 20:27
…ocation (dotnet#4005)

* Update the title to reflect that a single code issue is fixed per invocation

* Fix typo
* Use the new completion and completion/resolve services being added to the roslyn backend for a better overall completion experience.

* Be more threadsafe.

* Add additional tests, including an override completion test.

* Correct line/column handling.

* Add an option to support the forthcoming unimported type completion from Omnisharp.

* Adjust wording of the description.

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
* Fix typo

* Update package.json

* Update assets.ts
Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
Co-authored-by: N. Taylor Mullen <nimullen@microsoft.com>
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update Razor packages

* feedback

* Update package.lock.json
This is the vscode side of OmniSharp/omnisharp-roslyn#1941. This is written in such a fashion as to be mergeable now, as it will fall back to InsertText if TextEdit is not present in the completion response. After some appropriate period of time, we can remove the InsertText component.
* Razor Extension 6.0.0-alpha.1.20475.2

* 6.0.0-alpha.1.20479.2

* Update package.json

* Update package.json

* Update CHANGELOG.md

* Linking Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: N. Taylor Mullen <nimullen@microsoft.com>

Co-authored-by: N. Taylor Mullen <nimullen@microsoft.com>
Also added ARM and ARM64
The code action provider and rename provider were expecting the server to apply the file changes, which then messes up incremental buffer changes. This sends for false for these parameters, and refactors the handling of code action responses to do the renames locally. As part of that, I also refactored the protocol to accurately reflect O#'s hierarchy, and share the edit building between the fixAllProvider and the runCodeAction provider. Fixes dotnet#4128.
@333fred 333fred closed this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.