Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug scrollbar sync with light/dark mode #115

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

Ajay9330
Copy link
Contributor

@Ajay9330 Ajay9330 commented Mar 27, 2024

Description:

fixing the minor issue #114 that is sync scrollbar with light and dark mode

Issue fixed: #114

Changes done:

  • changed the index.css file

Screenshots/Videos

image
image

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Tried squashing the commits into one

@Ajay9330 Ajay9330 marked this pull request as ready for review March 27, 2024 20:58
@Ajay9330
Copy link
Contributor Author

Ajay9330 commented Mar 27, 2024

@aaronbrethorst sir please check this
i'm also getting this same issue with the ace editor but not got efficient solution, but try to fix that also in future commits will fully solving the problem

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but there's a merge conflict.

@Ajay9330
Copy link
Contributor Author

Ok sir, I'll try to resolve the conflict, ASAP

@Ajay9330
Copy link
Contributor Author

conflict-resolve but unable to squash the commits

@aaronbrethorst
Copy link
Member

  1. Always use a branch instead of working off your own main branch
  2. git rebase -i main
  3. Change picks 2-n to squash

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronbrethorst aaronbrethorst merged commit 3694b13 into OneBusAway:main Apr 12, 2024
2 checks passed
@Ajay9330
Copy link
Contributor Author

Ajay9330 commented Apr 12, 2024

Thank You sir,
I first time tried to rebase get little bit afraid of nano/vim editor!,
but now i got it! and also i have to preserve main branch because it is main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Bug : Scrollbar color not sync with the light and dark mode
2 participants