Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug of unable to click on the footer links due to the overflow #121

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

PeritusDeveloper
Copy link
Contributor

Description:

Fixing the minor issue #120 that is unable to click on footer links due to overflow.
The footer links could not be clicked when the hidden sidebar which had height full, aligned with the footer links

Issue fixed: #120

Changes done:

  • changed the default.erb file

Screenshots/Videos

Before Change
image

After Change
image

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Tried squashing the commits into one

The footer links could not be clicked when the hidden sidebar which had full height, aligned with the footer links
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work and good catch.

@aaronbrethorst aaronbrethorst merged commit 4923141 into OneBusAway:main Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Bug unable to click on the footer links due to the overflow
3 participants