Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbar styles for light and dark modes #83

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

tarunsinghofficial
Copy link
Contributor

@tarunsinghofficial tarunsinghofficial commented Mar 13, 2024

Description:

The current scrollbars in the docs don't look good or match the docs theme. To achieve the desired visual consistency and aesthetics across our project, I would like to enhance them across the whole site.

Issue fixed:

Enhancing the scrollbar in the entire docs to the matched theme i.e., dark colors for now.

Fixes #71

Changes done:

  • Task 1

Screenshots/Videos

Before:
image

After:
image

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Tried squashing the commits into one

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is definitely an improvement, but I see one regression that I want fixed: on a Mac with a trackpad, the scrollbars only appear when actively scrolling. That is no longer the case with this PR, and I'd like that contingency handled.

2024-03-14 11 43 22

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work; there's a merge conflict with index.css that will need to be fixed before merging though.

@tarunsinghofficial
Copy link
Contributor Author

great work; there's a merge conflict with index.css that will need to be fixed before merging though.

Got it. Resolved the conflicts.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronbrethorst aaronbrethorst merged commit c7b174d into OneBusAway:main Mar 27, 2024
2 checks passed
aaronbrethorst added a commit that referenced this pull request Mar 27, 2024
Fixes a regression introduced in #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enhance the scrollbar according to docs theme
2 participants