Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Ignore Live Activities code for Mac Catalyst #1005

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Jun 25, 2024

Description

One Line Summary

Fix Mac Catalyst builds by ignoring offending Live Activities code.

Details

  • We fixed Mac Catalyst Live Activities build issues in native SDK OneSignalLiveActivities framework included for mac catalyst OneSignal-iOS-SDK#1446
  • However, this wrapper SDK has code that reference OneSignalLiveActivitiesManagerImpl directly which is in a module not available to Mac Catalyst due to ActivityKit dependency
  • Therefore, it caused build failures for Mac Catalyst.
  • Live Activities does not work for Mac anyway, so just ignore these methods.

Motivation

Fix builds, address followup report here OneSignal/OneSignal-iOS-SDK#1445.

Scope

  • No op Live Activities for Mac Catalyst

Testing

Unit testing

None

Manual testing

Tested on my Mac Catalyst - builds, Live Activities is no-op
Tested on iPhone - builds, Live Activities setup is done

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

* These codes reference `OneSignalLiveActivitiesManagerImpl` directly which is in a module not available to Mac Catalyst due to ActivityKit dependency
* Therefore, it caused build failures for Mac Catalyst.
* Live Activities does not work for Mac anyway, so just ignore these methods.
@webbpage
Copy link

@emawby @jennantilla please comment what is required for approval.

@nan-li nan-li merged commit 075ed4d into main Jun 28, 2024
3 checks passed
@nan-li nan-li deleted the fix/mac_catalyst_live_activities branch June 28, 2024 19:21
This was referenced Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants